Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: latest version warnings can be less eager #24504

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Aug 21, 2024

If we release a number of fixes in a short amount of time then the version warning can warn you to upgrade after only one or two days... see https://posthog.com/questions/how-to-turn-off-the-your-post-hog-sdk-needs-updating-message

Since we're eager on reporting folk who are using deprecated versions, we can be a little less eager for minor version bumps

(also avoids returning a warning if there is no version string to resolve #24479)

@pauldambra pauldambra requested a review from a team August 21, 2024 11:48
Copy link
Contributor

github-actions bot commented Aug 21, 2024

Size Change: +747 B (+0.07%)

Total Size: 1.08 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.08 MB +747 B (+0.07%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra pauldambra merged commit 8535a96 into master Aug 21, 2024
93 checks passed
@pauldambra pauldambra deleted the fix/latest-versions-warning branch August 21, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Warning about posthog-js version displayed even when project doesn't appear to use it
5 participants