feat: make group identify props easier to find in replay #24497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
neilkakkar
approved these changes
Aug 21, 2024
| @@ -64,6 +64,8 @@ export function ItemEvent({ item, expanded, setExpanded }: ItemEventProps): JSX. | |||
| let promotedKeys: string[] | undefined = undefined | |||
| if (item.data.event === '$pageview') { | |||
| promotedKeys = ['$current_url', '$title', '$referrer'] | |||
| } else if (item.data.event === '$groupidentify') { | |||
| promotedKeys = ['$group_type', '$group_key', '$group_set'] | |||
pauldambra
deleted the
feat/make-group-identify-properties-easier-to-find
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a good conversation here https://posthog.com/questions/events-and-groups-in-session-replay
One thing that was clear - you had to know what properties you were looking for to make a group identify event useful in the replay inspector
This adds promoted properties for them to lift the three important properties to the top
(new visual regression snapshot will show what that looks like)