feat(web-analytics): Add pinnable actions and conversion goals #24398

robbie-c · 2024-08-15T14:55:04Z

Pinnable actions are finished with this PR, but conversion goals in web analytics aren't, but I'd like to get this merged to avoid more merge conflicts.

Problem

Conversion goals are one of the most requested things in web analytics, and would let people figure out % of users who e.g. reached a certain page / clicked on a certain button (i.e. autocapture) / performed a specific custom event.

Changes

We already have Actions as a concept in posthog, so this piggy-backs off this.

Add a concept of pinning actions. Pinned actions appear above unpinned actions in both web anaytics, and in the taxonomic filter component
Add a tile in web analytics, which lists the top N actions and shows the conversion rate for each one (by person id).

This part is WIP and hidden behind a FF:

Not in this PR but will be in a follow-up

Web analytics: Add a page-level setting for the conversion goal. This is then shown as the overview as the global conversion rate, and other breakdowns on the page will show conversion % per breakdown (e.g. by country or device type)
Web analytics: A shortcut from the tile to manage goals
Web analytics: Some information on tile about the total number of users, so that the number of uniques makes sense in context
Web analytics: Empty state for the tile, prompting a user to create an action
Web analytics: click an action in the goals tile sets it as the goal for the page

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Updated the existing tests to make sure that pinning an action works.
Added some tests for the new query

posthog-bot · 2024-08-19T15:37:37Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-19T15:55:59Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-19T16:14:15Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T14:13:50Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T14:47:08Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T15:05:56Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T15:24:01Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T15:41:52Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T15:59:50Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T16:18:15Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T16:36:28Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T16:54:27Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T17:12:33Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T17:30:48Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-21T17:49:04Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-23T18:08:17Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

github-actions · 2024-08-23T18:51:55Z

Size Change: +79 B (+0.01%)

Total Size: 1.11 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	1.11 MB	+79 B (+0.01%)

_{compressed-size-action}

posthog-bot · 2024-08-23T18:53:09Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-23T19:39:54Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

frontend/src/scenes/data-management/actions/ActionsTable.tsx

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

robbie-c force-pushed the feature/add-pinned-actions-as-conversion-goals branch from e228041 to 0df5890 Compare August 19, 2024 15:21

robbie-c force-pushed the feature/add-pinned-actions-as-conversion-goals branch from 387d7ff to aee3baa Compare August 21, 2024 13:47

robbie-c force-pushed the feature/add-pinned-actions-as-conversion-goals branch from f4a30cc to 4839576 Compare August 23, 2024 17:50

robbie-c force-pushed the feature/add-pinned-actions-as-conversion-goals branch from a6f2fe3 to aec2b47 Compare August 23, 2024 18:35

robbie-c force-pushed the feature/add-pinned-actions-as-conversion-goals branch from 91da322 to 3a59663 Compare August 23, 2024 19:21

robbie-c force-pushed the feature/add-pinned-actions-as-conversion-goals branch 5 times, most recently from 9e617ec to 67fd39a Compare August 27, 2024 14:05

robbie-c marked this pull request as ready for review August 27, 2024 14:54

robbie-c force-pushed the feature/add-pinned-actions-as-conversion-goals branch 2 times, most recently from 64c8596 to 1151098 Compare August 28, 2024 11:47

anirudhpillai reviewed Aug 30, 2024

View reviewed changes

frontend/src/scenes/data-management/actions/ActionsTable.tsx Outdated Show resolved Hide resolved

robbie-c requested a review from anirudhpillai August 30, 2024 13:11

robbie-c and others added 19 commits August 30, 2024 14:13

Add pinnable actions

edc6fd4

WIP goals query

51f8e76

Add working tests for empty

da10877

Fix up tests

ddb110d

Put Goals behind a FF

61fb8cd

Fix datetime

e391815

Typescript

6a70052

Fix actions tests

3a136c7

Action matcher tests

04bd5ed

Update UI snapshots for chromium (1)

037387c

Tests

032fbe5

Reduce with of goals, add retention title

97393aa

Fix tests

ccab904

Revert retention changes

adffe8d

Fix test

a34f617

Snapshot

3a8563d

Put visitors before conversion counts

aa24718

Add empty state and manage actions

7805179

Fix tooltips

0ebb5c4

robbie-c force-pushed the feature/add-pinned-actions-as-conversion-goals branch from 2bf1605 to 0ebb5c4 Compare August 30, 2024 13:14

robbie-c enabled auto-merge (squash) August 30, 2024 13:15

anirudhpillai approved these changes Aug 30, 2024

View reviewed changes

Fix tests

f2cd1f0

robbie-c merged commit c972f71 into master Aug 30, 2024
92 checks passed

robbie-c deleted the feature/add-pinned-actions-as-conversion-goals branch August 30, 2024 14:41

MarconLP pushed a commit that referenced this pull request Sep 6, 2024

feat(web-analytics): Add pinnable actions and conversion goals (#24398)

e869c77

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(web-analytics): Add pinnable actions and conversion goals #24398

feat(web-analytics): Add pinnable actions and conversion goals #24398

robbie-c commented Aug 15, 2024 •

edited

Loading

posthog-bot commented Aug 19, 2024

posthog-bot commented Aug 19, 2024

posthog-bot commented Aug 19, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 21, 2024

posthog-bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024 •

edited

Loading

posthog-bot commented Aug 23, 2024

posthog-bot commented Aug 23, 2024

feat(web-analytics): Add pinnable actions and conversion goals #24398

feat(web-analytics): Add pinnable actions and conversion goals #24398

Conversation

robbie-c commented Aug 15, 2024 • edited Loading

Problem

Changes

Does this work well for both Cloud and self-hosted?

How did you test this code?

posthog-bot commented Aug 19, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 19, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 19, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 21, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 23, 2024

📸 UI snapshots have been updated

github-actions bot commented Aug 23, 2024 • edited Loading

posthog-bot commented Aug 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 23, 2024

📸 UI snapshots have been updated

robbie-c commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 23, 2024 •

edited

Loading