fix(popover): use the top placement by default for the person display popover #24298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarticus
commented
Aug 9, 2024
Comment on lines
+122
to
+123
| placement="top" | ||
| fallbackPlacements={['bottom', 'right']} |
There was a problem hiding this comment.
@benjackwhite ,you were the last person to touch this area of the product. I checked out other data tables in the UI where we display person data and my changes looked safe, but any risks from your perspective about changing this?
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
Phanatic
approved these changes
Aug 9, 2024
benjackwhite
approved these changes
Aug 12, 2024
Comment on lines
+122
to
+123
| placement="top" | ||
| fallbackPlacements={['bottom', 'right']} |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have an issue where the person display box doesn't render correctly on a few browsers (chrome, arc), and appears off to the right
I think it'd be better to appear on the top by default, that way folks can easily see all the person info on popover if they'd like.
e.g.
Changes
https://www.loom.com/share/4379043cb6854a3ca8bc3666e9599066?sid=1a00b0c7-9eca-4092-9c22-68788cf1dc9d
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
👀