Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(retention): fix displaying of conditional elements in modal #24285

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

thmsobrmlr
Copy link
Contributor

Problem

The "00" here:

Screenshot 2024-08-09 at 12 32 29

Changes

Screenshot 2024-08-09 at 12 38 51

How did you test this code?

Tried it

@thmsobrmlr thmsobrmlr requested a review from a team August 9, 2024 10:39
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Size Change: 0 B

Total Size: 1.07 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.07 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr force-pushed the fix-retention-modal-conditionals branch from 3d9d05e to d1c44a2 Compare August 9, 2024 13:44
@thmsobrmlr thmsobrmlr enabled auto-merge (squash) August 9, 2024 13:44
@thmsobrmlr thmsobrmlr merged commit 0d07fe8 into master Aug 9, 2024
93 checks passed
@thmsobrmlr thmsobrmlr deleted the fix-retention-modal-conditionals branch August 9, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants