fix(surveys): lt/gt operator error in survey creation

[silentninja]

Problem

Fixes #22361

Changes

The query for checking the feature flag conditions failed when conditions employed numeric operators. This occurred because we check the property type before doing the comparison and the annotation needed for the property type check is missing. This PR addresses the issue by adding the missing property type annotations.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

I included test cases to verify the fix in this PR and also did a manual test.

[dmarticus]

great work, thanks for this! Let me see about getting CI passing but it seems like it's some dumb permissions thing that's blocking it.

[dmarticus]

@silentninja Not sure if you say this failing CI job, but it looks like one of the tests is failing still

FAILED ee/billing/test/test_billing_manager.py::TestBillingManager::test_update_billing_organization_users_with_multiple_members - AssertionError: assert equals failed
  [                                [                               
                                   +  {�                             
                                   +    'distinct_id': 'as0M8UVaE0t� 
                                   +0B8DvwIJ983byI4mmFEBRrlLuQU4B4R� 
                                   +h',�                             
                                   +    'email': '[email protected]',�        
                                   +    'role': 8,�                  
                                   +  },�                            
    {                                {                             
      'distinct_id': '2e5NgSciaOB      'distinct_id': '2e5NgSciaOB 
  qfZqGtTSCMsnGzLvomxcLFkJ9MeRvZn  qfZqGtTSCMsnGzLvomxcLFkJ9MeRvZn 
  ',                               ',                              
      'email': '[email protected]',             'email': '[email protected]',        
      'role': 15,                      'role': 15,                 
    },                               },                            
  -  {�                                                              
  -    'distinct_id': 'as0M8UVaE0t�                                  
  -0B8DvwIJ983byI4mmFEBRrlLuQU4B4R�                                  
  -h',�                                                              
  -    'email': '[email protected]',�                                         
  -    'role': 8,�                                                   
  -  },�                                                             
  ]                                ]
========== 1 failed, 656 passed, 5935 deselected in 440.42s (0:07:20) ==========

once you push that fix it should be good to go for us! I'm fixing the other CI failure on my end.

[silentninja]

@dmarticus Thanks for the heads up. I ran the tests locally, and they're passing as expected. The CI environment might be experiencing some flakiness with this particular test. Can you try rerunning the test suite?

[dmarticus]

@silentninja it's good to go! thanks for your contribution!