feat(web-analytics): Add a error tracking tile to web analytics #24273
Conversation
robbie-c
changed the title
| @@ -21,7 +21,8 @@ export function renderColumnMeta(key: string, query: DataTableNode, context?: Qu | |||
| let align: ColumnMeta['align'] | |||
|
|
|||
| const queryContextColumnName = key.startsWith('context.columns.') ? trimQuotes(key.substring(16)) : undefined | |||
| const queryContextColumn = queryContextColumnName ? context?.columns?.[queryContextColumnName] : undefined | |||
| const queryContextColumn = | |||
| (queryContextColumnName ? context?.columns?.[queryContextColumnName] : undefined) ?? context?.columns?.[key] | |||
There was a problem hiding this comment.
This was needed to get the align for the columns in the context to work. This fixed in the main error tracking scene as well.
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
robbie-c
force-pushed
the
feature/web-analytics-error-tracking
branch
from
fa7b48e to
a266f23
Compare
| @@ -1132,6 +1142,23 @@ export const webAnalyticsLogic = kea<webAnalyticsLogicType>([ | |||
| }, | |||
| } | |||
| : null, | |||
| featureFlags[FEATURE_FLAGS.ERROR_TRACKING] | |||
There was a problem hiding this comment.
I just used the error tracking FF, given we'll probably release this when we release that
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
robbie-c
force-pushed
the
feature/web-analytics-error-tracking
branch
from
8aa3e3b to
373d160
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Problem
People want to track errors :D
Changes
Add a tile for error tracking
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
It's behind a FF and still in alpha, so not really tested. I'm assuming team replay will test the main implementation though