Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): Add debug panel to saved insights #24262

Merged
merged 8 commits into from
Aug 12, 2024

Conversation

webjunkie
Copy link
Contributor

@webjunkie webjunkie commented Aug 8, 2024

Problem

We want to see if an insight is not calculating right (has only errors or a high error rate).

Changes

Add existing debug panel, but filtered for a single insight, thanks to better attribution in #24254

Also add stats for this insight.

image

How did you test this code?

Tested locally

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@webjunkie webjunkie changed the title feat(insights): Add debug panel to save insights feat(insights): Add debug panel to saved insights Aug 8, 2024
@webjunkie webjunkie force-pushed the feature/query-debugging-insight-panel branch from 07217da to 0a436d4 Compare August 8, 2024 16:29
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@webjunkie webjunkie force-pushed the feature/query-debugging-insight-panel branch from e57624b to e7084c5 Compare August 8, 2024 17:17
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@webjunkie webjunkie requested a review from a team August 9, 2024 10:06
# Conflicts:
#	frontend/__snapshots__/scenes-app-surveys--new-survey-appearance-section--light.png
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Size Change: 0 B

Total Size: 1.07 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.07 MB

compressed-size-action

@webjunkie webjunkie merged commit 500ec20 into master Aug 12, 2024
93 checks passed
@webjunkie webjunkie deleted the feature/query-debugging-insight-panel branch August 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants