Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(decide): another condition for request parsing errors #24250

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

dmarticus
Copy link
Contributor

@dmarticus dmarticus commented Aug 7, 2024

Problem

Noticed another condition where the data was ostensibly valid and we just needed to apply the correct transformation: https://posthog.sentry.io/issues/5680826999/events/2ec7bfd975594873a84ce8153388c6e2/

Correctly handles this transformation and then adds a test for it.

@dmarticus dmarticus requested a review from a team August 7, 2024 23:45
Copy link
Contributor

@Phanatic Phanatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@dmarticus dmarticus merged commit 9a6a47b into master Aug 9, 2024
88 checks passed
@dmarticus dmarticus deleted the fix/more-request-parsing-management branch August 9, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants