fix: duplicate merges in a single batch should be dropped #24242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverb123
changed the title
benjackwhite
requested changes
Aug 7, 2024
| // us to lock up PG, and if we're getting a large amount of duplicated merge events, bring down | ||
| // the whole pipeline. | ||
| if (['$create_alias', '$merge_dangerously', '$identify', '$anon_distinct_id'].includes(pluginEvent.event)) { | ||
| const alias = pluginEvent.properties?.alias || "I don't know what should be here" |
There was a problem hiding this comment.
Not sure this works... I would need to look into it a little more but I think $identify for example has a different property for the aliasing.
There was a problem hiding this comment.
I think it would need to be done deeper at the actual level of doing the merges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See https://posthog.slack.com/archives/C07FWU17XUJ - we should not process duplicate merge messages