-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hogql): better handling of known types for function calls #24237
Conversation
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Problem
HogQL doesn't know about the return types of functions, preventing us from having a fully-typed experience.
This can be seen in the generated ClickHouse SQL e.g.
2 = 1 + 1
currently becomes:After this PR it becomes the expected:
Further down the line we can add better auto-complete etc.
Todos
Changes
This PR adds signatures for most supported HogQL functions, as well as handling for the return types in HogQL.
How did you test this code?
CI run