fix(insights): Improve load more for breakdowns

[webjunkie]

Problem

It was only working if you selected "display other", because presumably you otherwise couldn't tell if more breakdown values are available.

Fixes #23554

Changes

• make it show up in all cases
• adjust the wording to have the actual values - since you also modify the query with this and it's persisted when you save
• use separate hasMore flag that is derived from "other" breakdowns being available. For this to work we ignore the hide_other flag and always calculate them, but hide the label+value later.

How did you test this code?

Tested locally

[posthog-bot]

📸 UI snapshots have been updated

62 snapshot changes in total. 0 added, 62 modified, 0 deleted:

• chromium: 0 added, 34 modified, 0 deleted (diff for shard 1, diff for shard 2)
• webkit: 0 added, 28 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[github-actions]

Size Change: +34 B (0%)

Total Size: 1.07 MB

ℹ️ View Unchanged

Filename	Size	Change
frontend/dist/toolbar.js	1.07 MB	+34 B (0%)

_{compressed-size-action}

[posthog-bot]

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

• chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

• chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

• chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[webjunkie]

@thmsobrmlr I've added a relatively quick approach/workaround to tell if there are actually more values. Can you check again? Also for experiments, I checked one and now the load more isn't there. But maybe that depends on certain conditions, so would be great if you can also check that.

[posthog-bot]

📸 UI snapshots have been updated

62 snapshot changes in total. 0 added, 62 modified, 0 deleted:

• chromium: 0 added, 34 modified, 0 deleted (diff for shard 1, diff for shard 2)
• webkit: 0 added, 28 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

• chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[thmsobrmlr]

Thanks for the follow-up @webjunkie! Works great now.

Did a couple of stylistic changes, hope you don't mind.

There's only one thing blocking this from merging now: The button only appears on a new insight, but not after saving. I'm assuming this has something to do with the insight serializer not returning the hasMore or similar.

[thmsobrmlr]

Also for experiments, I checked one and now the load more isn't there. But maybe that depends on certain conditions, so would be great if you can also check that.

This was just an artifact of the previous implementation where we would always display the button regardless if there are more values. Experiments only have two values and as such it's working there now.

[webjunkie]

with the insight serializer not returning the hasMore or similar.

Okay fixed this now. The hasMore is next to the results... which means it needs to go into the serializer as well. This whole area is a bit cumbersome. I wonder why no other insights had specific fields that needed to be included. We have hasMore also for other query responses, but it seems it's mostly actors responses that are not going to be the result of a saved insight 🤔

[thmsobrmlr]

with the insight serializer not returning the hasMore or similar.

Okay fixed this now. The hasMore is next to the results... which means it needs to go into the serializer as well. This whole area is a bit cumbersome. I wonder why no other insights had specific fields that needed to be included. We have hasMore also for other query responses, but it seems it's mostly actors responses that are not going to be the result of a saved insight 🤔

Yeah it's quite annoying. We did have other insights with problems here and probably still have some edge cases that are unhandled..