Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: need to release a new version, didn't like how this was worded #24223

Merged
merged 3 commits into from
Aug 6, 2024
Merged

fix: need to release a new version, didn't like how this was worded #24223

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8ce6c4
fix: need to release a new version, didn't like how this was worded
oliverb123 Aug 6, 2024
804494d
Update worker.rs
oliverb123 Aug 6, 2024
92dbb5a
clippy
oliverb123 Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions rust/hook-worker/src/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,6 @@ async fn process_batch<'a>(
let results = join_all(futures).await;

if hog_mode {
// System relevant - this means that our requests are at-least once, since if we do the
// request, it succeeds, and then our kafka is down, we'll do the request again. This was
// already true on batch commit, but now it's true on kafka send as well. We could add a
// "returned" state to the state machine that indicates "we made the request but haven't
// pushed it to kafka yet", but we need to decide that's something we care about first.
if (push_hoghook_results_to_kafka(
results,
metadata_vec,
Expand Down
Loading