Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdp): Track event for hog function state transitions #24217

Merged
merged 52 commits into from
Aug 9, 2024

Conversation

benjackwhite
Copy link
Contributor

Problem

Would be nice to know when a function is degraded etc. for us to get notifications.

Changes

  • Adds the event tracking
  • Refactors the hog function manager to make the caching logic easier to work with.
  • Fixes the distinct_id being plugin-server which can't be right
  • Adds shutdown to the pluginserver to ensure events get sent

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite requested a review from a team August 6, 2024 10:30
…g-events

# Conflicts:
#	plugin-server/src/cdp/hog-watcher/hog-watcher.ts
@benjackwhite benjackwhite changed the base branch from master to feat/cdp-hog-watcher-v3 August 8, 2024 09:11
Base automatically changed from feat/cdp-hog-watcher-v3 to master August 8, 2024 13:58
An error occurred while trying to automatically change base from feat/cdp-hog-watcher-v3 to master August 8, 2024 13:58
# Conflicts:
#	plugin-server/src/cdp/hog-watcher.ts
#	plugin-server/tests/cdp/hog-watcher.test.ts
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Size Change: 0 B

Total Size: 1.07 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.07 MB

compressed-size-action

benjackwhite and others added 2 commits August 9, 2024 09:14
# Conflicts:
#	frontend/__snapshots__/exporter-exporter--user-paths-insight--light.png
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite benjackwhite merged commit f21fe16 into master Aug 9, 2024
86 checks passed
@benjackwhite benjackwhite deleted the feat/cdp-posthog-events branch August 9, 2024 08:55
thmsobrmlr pushed a commit that referenced this pull request Aug 9, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants