fix(insights): only show confirmation when navigating to new url #24216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We show the "Leave insight?" confirmation when navigating to a new insight via the
urls.insightNew
helper.Repro:
Changes
This is because we redirect from non-project URLs to project URLs and vice-versa (
/project/1/insight/new
vs/insight/new
). Removing the project part from both pathnames makes our existing check work.How did you test this code?
Tried the repro before and after