Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Uploadable organization logo #24213

Merged
merged 23 commits into from
Aug 8, 2024
Merged

feat: Uploadable organization logo #24213

merged 23 commits into from
Aug 8, 2024

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Aug 6, 2024

Problem

Environments are coming to PostHog, but having the org, project, and environment spelled out in breadcrumbs would make the top bar pretty cluttered.

Changes

You can now upload hedgehogs:

logo

How did you test this code?

Some new component stories.

@Twixes Twixes requested a review from a team August 6, 2024 08:17
@posthog-bot

This comment was marked as off-topic.

@posthog-bot

This comment was marked as off-topic.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

73 snapshot changes in total. 0 added, 73 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Size Change: +34 B (0%)

Total Size: 1.07 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.07 MB +34 B (0%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this has the padding on top

@Twixes Twixes merged commit 8233b4f into master Aug 8, 2024
93 checks passed
@Twixes Twixes deleted the org-logo branch August 8, 2024 14:31
silentninja pushed a commit to silentninja/posthog that referenced this pull request Aug 8, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants