feat: update billing manager sync to use a single func #24205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow up to https://github.com/PostHog/billing/pull/797 and https://github.com/PostHog/billing/pull/817.
We want to sync more useful user data into billing to trigger the emails/events. We don't have the proper email/distinct id/role information right now.
This PR does two things:
org_admin_user
to the sync withdinstinct_id
,email
androle
. This is only for admins and owners because billing-related notifications are needed only for admins and owners.Given this is only syncing admins and owners it's not adding to much extra data.
The hope with this is we will be able to trigger events in billing that can then use the CDP to trigger emails whether than be in c.io or the CDP directly.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
It doesn't have an impact
How did you test this code?
Updated tests