-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(insights): add missing filter response for StickinessQueryRunner #24199
feat(insights): add missing filter response for StickinessQueryRunner #24199
Conversation
Hey @sanskar-soni-9, thanks for your work here! I'm tempted to merge this as it solves the immediate customer issue. However this adds back usage of legacy filters, that we're trying to get rid of. It would be better if this PR would change the tooltip to use the interval from the query. We seem to do so already for the x-axis on the chart where the dates are correct - maybe you can have a look there and see if a more long term solution is viable? |
40bbe95
to
eb94455
Compare
@thmsobrmlr As suggested I took the title from x-axis and its working perfectly when we have "no comparison between periods" but in case of comparison its generating wrong date as x-axis is filled with here are the previews |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Problem
Fixes issue #22209 by adding
filter
inquery
responseChanges
Added
_query_to_filter
method in StickinessQueryRunner (Also added TODO comment as similar found in trends_query_runner.py)Does this work well for both Cloud and self-hosted?
it doesn't have an impact.
How did you test this code?
tested with updated tests