fix(ingestion): Use $os_name as fallback for $os
#24184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
approved these changes
Aug 6, 2024
benjackwhite
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Addresses PostHog/posthog-js-lite#244: some libraries save the OS name as
$os(e.g.posthog-js) and others as$os_name(e.g.posthog-react-native). Fixing this "properly" requires customers to roll out an update of our SDK, so @marandaneto and I propose also adding an$os_name→$osaliasing layer to ingestion.Changes
Building on #17393 to add special handling of
$os_name. If$osisn't present, it's populated based on$os_name, along with$set.$osand$set_once.$initial_os.How did you test this code?
Added a unit test.