chore: Simplify layouts #24129
Closed
chore: Simplify layouts #24129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
approved these changes
Aug 1, 2024
📸 UI snapshots have been updated33 snapshot changes in total. 0 added, 33 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
# Conflicts: # frontend/__snapshots__/scenes-app-dashboards--edit--dark.png # frontend/__snapshots__/scenes-app-dashboards--edit--light.png # frontend/__snapshots__/scenes-app-dashboards--show--dark.png # frontend/__snapshots__/scenes-app-dashboards--show--light.png # frontend/__snapshots__/scenes-app-pipeline--pipeline-destinations-page--dark.png # frontend/__snapshots__/scenes-app-pipeline--pipeline-destinations-page--light.png # frontend/__snapshots__/scenes-app-pipeline--pipeline-site-apps-page--dark.png # frontend/__snapshots__/scenes-app-pipeline--pipeline-site-apps-page--light.png # frontend/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--dark.png # frontend/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--light.png # frontend/__snapshots__/scenes-app-pipeline--pipeline-transformations-page-empty--dark.png # frontend/__snapshots__/scenes-app-pipeline--pipeline-transformations-page-empty--light.png # frontend/__snapshots__/scenes-app-saved-insights--card-view--dark.png # frontend/__snapshots__/scenes-app-saved-insights--card-view--light.png
📸 UI snapshots have been updated46 snapshot changes in total. 0 added, 46 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Rebased version of #24120
Part of a separate branch working on a proposed new Explore tab - needed to make some changes to make this more flexible
Changes
app-rawtoapp-no-marginand reworked it so the scene is always flexing👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?