Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable dashboard insights refresh chaining #24057

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

anirudhpillai
Copy link
Contributor

@anirudhpillai anirudhpillai commented Jul 29, 2024

Problem

Temporary fix for https://posthoghelp.zendesk.com/agent/tickets/15410
Where one broken insight on the dashboard prevents entire dashboard from refreshing as insights are refreshed one at a time

Changes

Disable 'chaining' for dashboard insight refresh.
When /dashboard refresh is triggered, all the insights on it are refreshed in parallel (instead of sequentially before), so one slow insight won't hold back the other insight.

Impact is more async queries per dashboard. But we still limit concurrency per team here

Caveats

  1. The UI still polls 2 insights at a time so if 2 broken insights on a dashboard are polled first then they'll both prevent the UI from reading updated results for other insights. Can increase this limit?
  2. Haven't disabled chaining for shared dashboards yet but would make sense to disable that as well.

Does this work well for both Cloud and self-hosted?

N/A

How did you test this code?

Tested locally by replicating user scenario.

@anirudhpillai anirudhpillai requested a review from a team July 29, 2024 18:25
@Twixes Twixes merged commit fb0608b into master Jul 29, 2024
88 checks passed
@Twixes Twixes deleted the fix/disable-dashboard-insight-refresh-chaining branch July 29, 2024 22:58
Copy link

sentry-io bot commented Aug 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ CHQueryErrorTimeoutExceeded: DB::Exception: Timeout exceeded: elapsed 91.684698318 seconds, maximum: 60. Stack trace: /api/projects/{parent_lookup_team_id}/dashboard... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants