Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make error contact point to support modal #24048

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Conversation

joethreepwood
Copy link
Contributor

Problem

I have no idea if this will work, but always good to try and give things a go.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Member

@MarconLP MarconLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that file is missing the openEmailForm function

const { openEmailForm, closeEmailForm } = useActions(theLogic)

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@MarconLP
Copy link
Member

2024-07-30 at 15 44 23

@MarconLP MarconLP requested a review from a team July 30, 2024 13:47
Copy link
Contributor

github-actions bot commented Jul 30, 2024

Size Change: 0 B

Total Size: 1.07 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.07 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

# Conflicts:
#	frontend/__snapshots__/scenes-app-errortracking--group-page--dark.png
#	frontend/__snapshots__/scenes-app-errortracking--group-page--light.png
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@MarconLP MarconLP enabled auto-merge (squash) July 30, 2024 15:58
@MarconLP MarconLP merged commit 5e837f4 into master Jul 31, 2024
92 checks passed
@MarconLP MarconLP deleted the contact-support-modal branch July 31, 2024 09:31
fuziontech added a commit that referenced this pull request Jul 31, 2024
…into delete_test_fixes

* 'delete_test_fixes' of https://github.com/PostHog/posthog: (22 commits)
  chore(deps): Update posthog-js to 1.153.0 (#24113)
  fix: series with different current and previous breakdowns are throwing errors  (#24092)
  chore(deps): Update posthog-js to 1.152.1 (#24110)
  fix(bi): Use a better tooltip mode for graphs (#24101)
  feat(bi): Added support for decimal numbers in BI (#24103)
  fix: Site app url for early access (#24104)
  feat(cdp): Added mailjet templates (#24096)
  fix: dry run output was inaccurate (#24075)
  feat: Add batch utilization metric for blobby (#24094)
  chore(deps): Update posthog-js to 1.151.2 (#24106)
  fix: limit metadata reloading (#24099)
  chore: remove useless draft files (#24102)
  feat(data-warehouse): Added the ability to use dashboard filters in BI queries (#24033)
  chore(deps): Update posthog-js to 1.151.1 (#24098)
  fix: Pipeline activity logs (#24077)
  feat(BI): Series settings (#24082)
  feat(dev): add separate env var for disabling navigation hooks (#24097)
  fix(web-analytics): Fix empty channel types (#24087)
  fix: Make error contact point to support modal (#24048)
  feat(notebooks): add error boundary around components (#24095)
  ...
silentninja pushed a commit to silentninja/posthog that referenced this pull request Aug 8, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: MarconLP <[email protected]>
Co-authored-by: Thomas Obermüller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants