feat(data-warehouse): Added the ability to use dashboard filters in BI queries #24033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gilbert09
changed the title
Gilbert09
temporarily deployed
to
pypi-hogql-parser
GitHub Actions
Inactive
Twixes
reviewed
Jul 30, 2024
posthog/hogql/query.py
Outdated
Comment on lines
79
to
89
| if "filters" in placeholders_in_query or any( | ||
| placeholder.startswith("filters.") for placeholder in placeholders_in_query | ||
| ): | ||
| select_query = replace_filters(select_query, filters, team) | ||
| placeholders_in_query.remove("filters") | ||
|
|
||
| removed_placeholders: list[str] = [] | ||
| for placeholder in placeholders_in_query: | ||
| if placeholder == "filters": | ||
| removed_placeholders.append(placeholder) | ||
| elif placeholder.startswith("filters."): | ||
| removed_placeholders.append(placeholder) |
There was a problem hiding this comment.
We anyway iterate over placeholders_in_query at least once in this block, so why not rewrite to only do it once, skipping over the irrelevant placeholders?
There was a problem hiding this comment.
We could still rewrite this block only have for placeholder in placeholders_in_query once, but that's minor
There was a problem hiding this comment.
Sorry, yep, missed this!
|
It looks like the code of |
Gilbert09
temporarily deployed
to
pypi-hogql-parser
GitHub Actions
Inactive
Twixes
approved these changes
Jul 31, 2024
posthog/hogql/query.py
Outdated
Comment on lines
79
to
89
| if "filters" in placeholders_in_query or any( | ||
| placeholder.startswith("filters.") for placeholder in placeholders_in_query | ||
| ): | ||
| select_query = replace_filters(select_query, filters, team) | ||
| placeholders_in_query.remove("filters") | ||
|
|
||
| removed_placeholders: list[str] = [] | ||
| for placeholder in placeholders_in_query: | ||
| if placeholder == "filters": | ||
| removed_placeholders.append(placeholder) | ||
| elif placeholder.startswith("filters."): | ||
| removed_placeholders.append(placeholder) |
There was a problem hiding this comment.
We could still rewrite this block only have for placeholder in placeholders_in_query once, but that's minor
Co-authored-by: Michael Matloka <[email protected]>
|
It looks like the code of |
Gilbert09
temporarily deployed
to
pypi-hogql-parser
GitHub Actions
Inactive
fuziontech
added a commit
that referenced
this pull request
Jul 31, 2024
…into delete_test_fixes * 'delete_test_fixes' of https://github.com/PostHog/posthog: (22 commits) chore(deps): Update posthog-js to 1.153.0 (#24113) fix: series with different current and previous breakdowns are throwing errors (#24092) chore(deps): Update posthog-js to 1.152.1 (#24110) fix(bi): Use a better tooltip mode for graphs (#24101) feat(bi): Added support for decimal numbers in BI (#24103) fix: Site app url for early access (#24104) feat(cdp): Added mailjet templates (#24096) fix: dry run output was inaccurate (#24075) feat: Add batch utilization metric for blobby (#24094) chore(deps): Update posthog-js to 1.151.2 (#24106) fix: limit metadata reloading (#24099) chore: remove useless draft files (#24102) feat(data-warehouse): Added the ability to use dashboard filters in BI queries (#24033) chore(deps): Update posthog-js to 1.151.1 (#24098) fix: Pipeline activity logs (#24077) feat(BI): Series settings (#24082) feat(dev): add separate env var for disabling navigation hooks (#24097) fix(web-analytics): Fix empty channel types (#24087) fix: Make error contact point to support modal (#24048) feat(notebooks): add error boundary around components (#24095) ...
silentninja
pushed a commit
to silentninja/posthog
that referenced
this pull request
Aug 8, 2024
…I queries (PostHog#24033) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Matloka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
{filters.dateRange.from}and{filters.dateRange.to}in SQL queries when comparing with a datetimedateTois not set, then the comparison node gets effectively removed@Twixes @mariusandra some review of my C++ is code is very much needed please!! I've tried to join a
vector<string>with a delimiter (.) - I got to this code from googling and chatgpt, but please do correct me if I've done something horrifically wrong in the C++ world 🤓Usage:
TODO:
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tests to be added before this merges