fix(insights): query endpoint in e2e #24026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While e2e tests are running, the query status endpoint doesn't return a completed/failed response being stuck in the pending status. The problem is the execution mode of Celery
CELERY_ALWAYS_EAGER, which executes tasks synchronously. The task has already run and the cache stores its result, but we overwrite the result with data generated before the task is executed.Changes
Check if the task result is an instance of
EagerResultand retrieve fresh data from the cache if it is. Potentially, we want to removeCELERY_ALWAYS_EAGERin end-to-end tests and keep async tasks instead. The async execution might be an important part of the e2e flow.Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Manual testing in e2e flows.