Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch-exports): Remove duplicate configuration field #24009

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

tomasfarias
Copy link
Contributor

@tomasfarias tomasfarias commented Jul 26, 2024

Problem

The "Model" is duplicated and pops up in both the left and the right side of the configuration page:

image

Only the left side should be used.

Changes

Remove a field from configuration frontend.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@tomasfarias tomasfarias requested review from Gilbert09 and EDsCODE July 26, 2024 07:49
Copy link
Contributor

Size Change: 0 B

Total Size: 1.07 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.07 MB

compressed-size-action

@tomasfarias tomasfarias merged commit 0f64b40 into master Jul 26, 2024
95 checks passed
@tomasfarias tomasfarias deleted the fix/remove-unused-duplicate-field branch July 26, 2024 09:13
silentninja pushed a commit to silentninja/posthog that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants