Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-warehouse): only enable checkbox if sync method is set #24003

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jul 25, 2024

Problem

  • you can check the sync box on the schema form even without a sync method set up

Changes

  • disable unless sync method set up

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Size Change: 0 B

Total Size: 1.07 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.07 MB

compressed-size-action

@EDsCODE EDsCODE requested a review from Gilbert09 July 25, 2024 21:30
@EDsCODE EDsCODE merged commit cdca1a9 into master Jul 26, 2024
92 checks passed
@EDsCODE EDsCODE deleted the dw-setup-flow-adjustments branch July 26, 2024 13:13
silentninja pushed a commit to silentninja/posthog that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants