Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): first time for user math type for Actors Query #23993

Merged
merged 12 commits into from
Jul 29, 2024

Conversation

skoob13
Copy link
Contributor

@skoob13 skoob13 commented Jul 25, 2024

Problem

The PR adds support for the first time for user math type in Actors Query.

2024-07-29 11 39 25

Changes

  • Created a builder for the math type based on the existing QueryAlternator.
  • Re-used the query builder in ActorQuery and TrendsQuery.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Manual testing, e2e, unit tests, and new tests.

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Size Change: -8 B (0%)

Total Size: 1.07 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.07 MB -8 B (0%)

compressed-size-action

@skoob13 skoob13 force-pushed the feat/first-time-for-user-actors-query branch from 638bfa6 to 81690c4 Compare July 29, 2024 09:26
@skoob13 skoob13 requested a review from a team July 29, 2024 09:45
@skoob13 skoob13 marked this pull request as ready for review July 29, 2024 09:45
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@skoob13 skoob13 merged commit 8dc8399 into master Jul 29, 2024
85 checks passed
@skoob13 skoob13 deleted the feat/first-time-for-user-actors-query branch July 29, 2024 12:04
Copy link

sentry-io bot commented Aug 1, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: cannot unpack non-iterable int object posthog.tasks.tasks.process_query_task View Issue
  • ‼️ TypeError: dateutil.relativedelta.relativedelta() argument after ** must be a mapping, not NoneType posthog.tasks.tasks.process_query_task View Issue

Did you find this useful? React with a 👍 or 👎

silentninja pushed a commit to silentninja/posthog that referenced this pull request Aug 8, 2024
…og#23993)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants