Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Roll back sessions v2 #23990

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix: Roll back sessions v2 #23990

merged 1 commit into from
Jul 25, 2024

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Jul 25, 2024

Problem

There's been some issues with sessions v2, regarding the backfill. Let's revert until we can figure out what the problem was.

Changes

Put users with the auto setting back on v1

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

n/a We're reverting to what this used to be

@posthog-bot
Copy link
Contributor

Hey @robbie-c! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link

sentry-io bot commented Jul 25, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/hogql/database/database.py

Function Unhandled Issue
create_hogql_database KeyError: 'all_data_target_new' posthog.tasks.tas...
Event Count: 1
create_hogql_database KeyError: 'test' posthog.tasks.tasks.process_quer...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@robbie-c robbie-c requested review from Twixes and anirudhpillai July 25, 2024 15:12
@robbie-c robbie-c enabled auto-merge (squash) July 25, 2024 15:16
@robbie-c robbie-c merged commit 71d5877 into master Jul 25, 2024
88 checks passed
@robbie-c robbie-c deleted the fix/roll-back-session-v2 branch July 25, 2024 15:49
zlwaterfield pushed a commit that referenced this pull request Jul 25, 2024
robbie-c added a commit that referenced this pull request Jul 29, 2024
silentninja pushed a commit to silentninja/posthog that referenced this pull request Aug 8, 2024
silentninja pushed a commit to silentninja/posthog that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants