fix(web-analytics): Use events rather than sharded_events for raw_sessions backfill #23989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
force-pushed
the
fix/raw_sessions_backfill
branch
from
b3c5393 to
d8fe368
Compare
daibhin
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I believe this is the root cause for some users seeing a disceprency in their v1 vs v2 session table calculations.
The previous backfill script for v1 used
eventsrather thansharded_events, and worked as expected. It was a mistake to usesharded_eventsfor v2.I've had to revert the sessions table back to v1 for the time being, but this means that the bounce rate fix is also rolled back (i.e. bounce rate is broken again), so it'd be great to make forward progress on this ASAP
Changes
Change the backfill to use events rather than sharded_events
Does this work well for both Cloud and self-hosted?
Yes (though idk if self-hosted people are likely to run the backfill)
How did you test this code?
n/a