Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): use sql alchemy format for executing queries #23927

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jul 23, 2024

Problem

  • ci complaining

Changes

  • use the sql alchemy version of query formatting

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE requested a review from Gilbert09 July 23, 2024 19:04
@EDsCODE EDsCODE marked this pull request as draft July 23, 2024 19:06
@Gilbert09 Gilbert09 marked this pull request as ready for review July 23, 2024 19:23
@Gilbert09 Gilbert09 merged commit 59f9b7a into master Jul 23, 2024
87 checks passed
@Gilbert09 Gilbert09 deleted the dw-sqlalchemy-typing-2 branch July 23, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants