Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): add to baseline #23926

Merged
merged 2 commits into from
Jul 23, 2024
Merged

chore(data-warehouse): add to baseline #23926

merged 2 commits into from
Jul 23, 2024

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jul 23, 2024

Problem

  • ci complaining

Changes

  • let the cast happen after null check

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE marked this pull request as ready for review July 23, 2024 18:59
@thmsobrmlr thmsobrmlr self-requested a review July 23, 2024 18:59
@EDsCODE EDsCODE enabled auto-merge (squash) July 23, 2024 19:00
@EDsCODE EDsCODE changed the title chore(data-warehouse): don't specify typing immediately chore(data-warehouse): add to baseline Jul 23, 2024
@EDsCODE EDsCODE merged commit 0f55636 into master Jul 23, 2024
88 checks passed
@EDsCODE EDsCODE deleted the dw-sql-alchemy-typing branch July 23, 2024 19:10
silentninja pushed a commit to silentninja/posthog that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants