Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): submit form on enter #23925

Merged
merged 10 commits into from
Jul 23, 2024
Merged

chore(data-warehouse): submit form on enter #23925

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
891278a
submit on enter is pressed
EDsCODE Jul 23, 2024
d4c4a8a
use handler
EDsCODE Jul 23, 2024
023fb51
Update UI snapshots for `chromium` (2)
github-actions[bot] Jul 23, 2024
df37469
Merge branch 'master' into dw-on-enter
EDsCODE Jul 23, 2024
ac7f30c
Update UI snapshots for `chromium` (1)
github-actions[bot] Jul 23, 2024
92435c6
Update UI snapshots for `chromium` (1)
github-actions[bot] Jul 23, 2024
178313c
Update UI snapshots for `chromium` (1)
github-actions[bot] Jul 23, 2024
92fa2df
Update UI snapshots for `chromium` (1)
github-actions[bot] Jul 23, 2024
5a18b37
Update UI snapshots for `chromium` (1)
github-actions[bot] Jul 23, 2024
f22c275
Update UI snapshots for `chromium` (1)
github-actions[bot] Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified frontend/__snapshots__/scenes-app-dashboards--insight-legend--dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-edit--dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 9 additions & 1 deletion frontend/src/lib/lemon-ui/LemonDialog/LemonDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,15 @@ export const LemonFormDialog = ({
}, [])

return (
<Form logic={lemonDialogLogic} formKey="form">
<Form
logic={lemonDialogLogic}
formKey="form"
onKeyDown={(e: React.KeyboardEvent<HTMLFormElement>): void => {
if (e.key === 'Enter' && primaryButton?.htmlType === 'submit' && isFormValid) {
void onSubmit(form)
}
}}
>
<LemonDialog {...props} primaryButton={primaryButton} secondaryButton={secondaryButton} />
</Form>
)
Expand Down
Loading