fix(lemon-ui): Properly indicate clickable and disabled LemonTag #23853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
commented
Jul 19, 2024
| @@ -38,8 +38,8 @@ function CategoryPill({ | |||
| type={isActive ? 'primary' : canInteract ? 'option' : 'muted'} | |||
| data-attr={`taxonomic-tab-${groupType}`} | |||
| onClick={canInteract ? onClick : undefined} | |||
| weight="normal" | |||
| aria-disabled | |||
daibhin
approved these changes
Jul 19, 2024
| @@ -492,7 +492,7 @@ export function StatusTag({ survey }: { survey: Survey }): JSX.Element { | |||
| } as Record<ProgressStatus, LemonTagType> | |||
| const status = getSurveyStatus(survey) | |||
| return ( | |||
| <LemonTag type={statusColors[status]} style={{ fontWeight: 600 }} data-attr="status"> | |||
There was a problem hiding this comment.
Wonder how this crept in past the eslint rule? It was only added 3 months ago
There was a problem hiding this comment.
It looks like the rule only applies to props on HTML elements, and not React components 🤔
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Twixes
force-pushed
the
accessible-clickable-tag
branch
from
a759903 to
447478f
Compare
|
Size Change: +107 B (+0.01%) Total Size: 1.07 MB ℹ️ View Unchanged
|
zlwaterfield
pushed a commit
that referenced
this pull request
Jul 25, 2024
silentninja
pushed a commit
to silentninja/posthog
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It was weird that clickable but disabled tags behaved like text:
For some reason, all tags in that TaxonomicFilter UI were also marked
aria-disabled, always.Changes
Clickable tags now behave more like buttons (which they effectively are) and are accessible.