chore: use real structs in hoghook payloads #23763
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The manual JSON destructuring was ugly, and @xvello told me about
serde(flatten)
.Changes
Useflatten
to store extra fields, then reconstruct the JSON payload before inserting the job.The downside of
serde(flatten)
is we were mutating the incoming payload, risking an unexpected change to the passthrough data. Instead, I've adjusted it to the best of the both worlds: we usestruct
s to deserialize, but we do it only on a copy of the subset of data we care about -- that way the original incoming payload is totally unmodified.Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Existing tests covered all the edge cases.