-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate snippet methods #23663
Conversation
@neilkakkar i think you are the most diligent here... am i missing a trick? (oh you're out! i missed that - ignore me 💖 ) |
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
@pauldambra nope I just hear from customers very quickly when I don't add these 🙈 - your solution is much better than mine <3 |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
we all either forget or don't know to add methods from posthog-js to the snippet as we add them to posthog-js
computers are good at not forgetting
lets generate the list of methods from the current posthog installed when the snippet loads
we can squash duplication in the front end side
but our layout.html we'll have to manually update since that'd be what is loading posthog for us to operate on
now we generate
we used to have fixed
this adds missing methods