fix(insights): polishing of multiple breakdowns in Trends #23649

skoob13 · 2024-07-11T16:06:28Z

Problem

Fixes the following bugs related to the multiple breakdowns:

Map view didn't reset
The number total value viz didn't reset breakdowns
Smoothing dropdown was always visible for line graphs
InsightCard had a wrong letter color
The popup describing session usage didn't apply to multiple breakdowns
Activity didn't display multiple breakdowns in insights

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Unit and manual testing

github-actions · 2024-07-11T16:16:48Z

Size Change: 0 B

Total Size: 1.07 MB

ℹ️ View Unchanged

Filename	Size
`frontend/dist/toolbar.js`	1.07 MB

_{compressed-size-action}

posthog-bot · 2024-07-11T16:23:10Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…g/posthog into fix/multiple-breakdowns-polishing

posthog-bot · 2024-07-11T17:01:10Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

thmsobrmlr

Heya @skoob13, thanks for the follow up here! Overall the changes look good. I left a couple of comments inline. In general I think it would be good to dry up the code a bit, as its hard to understand as is. Might also be worth splitting into separate PRs in the future.

frontend/__snapshots__/components-cards-insight-details--trends-world-map--dark.png

frontend/src/lib/components/Cards/InsightCard/InsightDetails.tsx

frontend/src/scenes/insights/filters/BreakdownFilter/taxonomicBreakdownFilterLogic.ts

…g/posthog into fix/multiple-breakdowns-polishing

thmsobrmlr

Thanks for the follow-up @skoob13 ! This looks good now, with only one change that I think we should make before merging in: The current implementation would break the insight details for the other implementation of multi-breakdowns. I don't think we need to wait for the refactor to the same format and could instead just handle both formats gracefully there.

frontend/src/queries/utils.ts

frontend/src/lib/components/Cards/InsightCard/InsightDetails.tsx

…-breakdowns-polishing

posthog-bot · 2024-07-23T15:20:40Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T15:41:05Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T15:59:20Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T16:17:55Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T16:36:31Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…-breakdowns-polishing

posthog-bot · 2024-07-23T17:48:12Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T18:06:25Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-23T18:25:21Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

thmsobrmlr

Some CI unhappiness (looks unrelated), otherwise ready to go in 👍

…-breakdowns-polishing

posthog-bot · 2024-07-24T07:42:24Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…-breakdowns-polishing

…g/posthog into fix/multiple-breakdowns-polishing

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

skoob13 added 6 commits July 11, 2024 17:59

fix: reset a breakdown filter when BoldNumber is selected

1eb129f

fix: reset map view in multiple breakdowns

75bb13c

fix: InsightCard series letter for multiple breakdowns

c8f7151

fix: hide smoothing with breakdowns

f43affc

fix: show info popup for sessions

620d737

feat: serialize multiple breakdowns in activity

36360f9

skoob13 added the team/product-analytics label Jul 11, 2024

skoob13 requested a review from a team July 11, 2024 16:06

Update UI snapshots for chromium (2)

8ff6bf0

skoob13 and others added 3 commits July 11, 2024 18:29

fix: multiple breakdowns formatting

a665772

Merge branch 'fix/multiple-breakdowns-polishing' of github.com:PostHo…

13b3146

…g/posthog into fix/multiple-breakdowns-polishing

Update UI snapshots for chromium (2)

526e3db

thmsobrmlr reviewed Jul 12, 2024

View reviewed changes

skoob13 added 2 commits July 12, 2024 11:28

fix: pr comments

40c44b9

Merge branch 'fix/multiple-breakdowns-polishing' of github.com:PostHo…

3ac0fcc

…g/posthog into fix/multiple-breakdowns-polishing

skoob13 requested a review from a team July 17, 2024 12:49

thmsobrmlr requested changes Jul 22, 2024

View reviewed changes

frontend/src/queries/utils.ts Outdated Show resolved Hide resolved

frontend/src/lib/components/Cards/InsightCard/InsightDetails.tsx Show resolved Hide resolved

skoob13 marked this pull request as draft July 22, 2024 17:54

skoob13 added 3 commits July 23, 2024 16:57

Merge branch 'master' of github.com:PostHog/posthog into fix/multiple…

7a6dc15

…-breakdowns-polishing

fix: compatibility with legacy breakdowns

8c22f56

fix: descriptive comment

905aca5

skoob13 requested a review from a team July 23, 2024 15:06

skoob13 marked this pull request as ready for review July 23, 2024 15:06

skoob13 and others added 2 commits July 23, 2024 17:14

test: fix

27b96ac

Update UI snapshots for chromium (1)

261abc4

Update UI snapshots for chromium (1)

159d100

Update UI snapshots for chromium (1)

2142366

Update UI snapshots for chromium (1)

cae9f78

Update UI snapshots for chromium (1)

10cd49c

skoob13 requested a review from thmsobrmlr July 23, 2024 17:27

skoob13 and others added 3 commits July 23, 2024 19:28

Merge branch 'master' of github.com:PostHog/posthog into fix/multiple…

3dfa316

…-breakdowns-polishing

Update UI snapshots for chromium (1)

65cd895

Update UI snapshots for chromium (2)

95a4b5d

Update UI snapshots for chromium (1)

8201cea

Update UI snapshots for chromium (1)

3a90078

thmsobrmlr approved these changes Jul 23, 2024

View reviewed changes

skoob13 and others added 2 commits July 24, 2024 09:22

Merge branch 'master' of github.com:PostHog/posthog into fix/multiple…

190ba5c

…-breakdowns-polishing

Update UI snapshots for chromium (1)

00f2712

skoob13 added 2 commits July 24, 2024 12:00

Merge branch 'master' of github.com:PostHog/posthog into fix/multiple…

30d8819

…-breakdowns-polishing

Merge branch 'fix/multiple-breakdowns-polishing' of github.com:PostHo…

b75188f

…g/posthog into fix/multiple-breakdowns-polishing

skoob13 enabled auto-merge (squash) July 24, 2024 10:01

skoob13 merged commit 6440ea5 into master Jul 24, 2024
90 checks passed

skoob13 deleted the fix/multiple-breakdowns-polishing branch July 24, 2024 10:17

thmsobrmlr pushed a commit that referenced this pull request Jul 24, 2024

fix(insights): polishing of multiple breakdowns in Trends (#23649)

bc12d36

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

thmsobrmlr pushed a commit that referenced this pull request Jul 25, 2024

fix(insights): polishing of multiple breakdowns in Trends (#23649)

662cdef

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

silentninja pushed a commit to silentninja/posthog that referenced this pull request Aug 8, 2024

fix(insights): polishing of multiple breakdowns in Trends (PostHog#23649

9b9dd21

) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(insights): polishing of multiple breakdowns in Trends #23649

fix(insights): polishing of multiple breakdowns in Trends #23649

skoob13 commented Jul 11, 2024

github-actions bot commented Jul 11, 2024 •

edited

Loading

posthog-bot commented Jul 11, 2024

posthog-bot commented Jul 11, 2024

thmsobrmlr left a comment

thmsobrmlr left a comment

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

posthog-bot commented Jul 23, 2024

thmsobrmlr left a comment

posthog-bot commented Jul 24, 2024

fix(insights): polishing of multiple breakdowns in Trends #23649

fix(insights): polishing of multiple breakdowns in Trends #23649

Conversation

skoob13 commented Jul 11, 2024

Problem

Does this work well for both Cloud and self-hosted?

How did you test this code?

github-actions bot commented Jul 11, 2024 • edited Loading

posthog-bot commented Jul 11, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 11, 2024

📸 UI snapshots have been updated

thmsobrmlr left a comment

Choose a reason for hiding this comment

thmsobrmlr left a comment

Choose a reason for hiding this comment

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 23, 2024

📸 UI snapshots have been updated

thmsobrmlr left a comment

Choose a reason for hiding this comment

posthog-bot commented Jul 24, 2024

📸 UI snapshots have been updated

github-actions bot commented Jul 11, 2024 •

edited

Loading