feat: track anonymous personfull events in usage reports #23461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raquelmsmith
commented
Jul 3, 2024
| WHERE timestamp between %(begin)s AND %(end)s | ||
| AND event != '$feature_flag_called' AND event NOT IN ('survey sent', 'survey shown', 'survey dismissed') | ||
| AND person_mode IN ('full', 'force_upgrade') | ||
| AND JSONExtractBool(properties, '$is_identified') = 0 |
There was a problem hiding this comment.
@robbie-c what if someone had used $set to add person properties - would they be considered identified from posthog.js?
zlwaterfield
approved these changes
Jul 3, 2024
| @@ -224,11 +224,12 @@ def bulk_create_events( | |||
|
|
|||
| except Group.DoesNotExist: | |||
| continue | |||
| properties = event.get("properties", {}) | |||
There was a problem hiding this comment.
This doesn't seems like it didn't anything.
posthog/tasks/usage_report.py
Outdated
| @@ -74,6 +74,7 @@ class UsageReportCounters: | |||
| event_count_in_period: int | |||
| enhanced_persons_event_count_in_period: int | |||
| event_count_with_groups_in_period: int | |||
| anonymous_personfull_event_count_in_period: int | |||
There was a problem hiding this comment.
Nit: shouldn't this have one l? "personful"
There was a problem hiding this comment.
We've used "personfull" in internal communications but I think it's a britishism, so yes changing to personful 😄
raquelmsmith
deleted the
feat/rms/usage-reports-would-have-been-personless
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to see how many of our events per customer are anonymous but personfull to see if we can make the anonymous events all personless.
Changes
In usage reports, adds a metric for anonymous personfull events.
I will re-run usage reports for the last few days so this metric shows up and we can run numbers from there.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Updated the tests, which annoyingly took forever, I think there are too many ways to do the same thing, or they're named poorly or something.