Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): polishing the popup survey UI #23460

Merged
merged 12 commits into from
Jul 5, 2024
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions frontend/src/scenes/surveys/SurveyEditQuestionRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,10 @@ export function SurveyEditQuestionGroup({ index, question }: { index: number; qu
const newQuestions = [...survey.questions]
newQuestions[index] = newQuestion
setSurveyValue('questions', newQuestions)
setSurveyValue(
'appearance.ratingButtonColor',
val === 'emoji' ? '#939393' : 'white'
)
Comment on lines +232 to +235
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes buggy behavior where we wouldn't update the colors correctly when we toggled the survey values.

Before

2024-07-03 13 47 40

After

2024-07-03 13 45 50

resetBranchingForQuestion(index)
}}
/>
Expand Down
Loading