refactor(insights): query based duplicateInsight
#23435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
force-pushed
the
duplicate-query-based-insight
branch
from
b94faf7 to
acae7df
Compare
thmsobrmlr
force-pushed
the
duplicate-query-based-insight
branch
from
acae7df to
a52762c
Compare
thmsobrmlr
force-pushed
the
duplicate-query-based-insight
branch
from
84f1b6c to
2027c9d
Compare
thmsobrmlr
commented
Jul 4, 2024
|
|
||
| type ReturnedInsightModelByFlag<Flag extends boolean> = Flag extends true ? QueryBasedInsightModel : InsightModel | ||
|
|
||
| export const insightsApi = { |
There was a problem hiding this comment.
I initially did the handling in lib/api.ts, but that doesn't work as (1) it's included in the toolbar and importing anything there explodes size (2) doing so breaks kea, likely due to some logics needing to be mounted in the right order. Therefore this wrapper.
|
Size Change: +134 B (+0.01%) Total Size: 1.07 MB ℹ️ View Unchanged
|
thmsobrmlr
commented
Jul 4, 2024
| sourceInsight.name = '' | ||
| sourceInsight.derived_name = 'should be copied' | ||
| await logic.asyncActions.duplicateInsight(sourceInsight) | ||
| expect(api.create).toHaveBeenCalledWith( | ||
| `api/projects/${MOCK_TEAM_ID}/insights`, | ||
| expect.objectContaining({ name: '' }) | ||
| expect.objectContaining({ name: '' }), | ||
| expect.objectContaining({}) |
There was a problem hiding this comment.
ApiRequest.create is implemented like this:
return await api.create(this.assembleFullUrl(), options?.data, options)Meaning the data gets repeated in options. I didn't want to change the implementation in this PR, therefore adjusting tests.
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
thmsobrmlr
changed the title
duplicateInsight
webjunkie
approved these changes
Jul 5, 2024
skoob13
approved these changes
Jul 8, 2024
# Conflicts: # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-breakdown--dark.png # frontend/src/scenes/saved-insights/SavedInsights.tsx
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
thmsobrmlr
added a commit
that referenced
this pull request
Jul 15, 2024
This reverts commit 307a783.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to have only query based insights frontend side, but we still need to send them to the backend with
filters. The bigger goal of the coming PRs is to adapt all instances where we send insights to the backend for persistance with a wrapper function, so that the frontend can happily live with query based insights only.Changes
This PR lets all instances of
duplicateInsighttake a query based insight and conditionally:filtersorqueryto the backend, based on a feature flagfiltersorquery, based on a boolean value -> work is in progress to set this totrueeverywhereHow did you test this code?
With flag disabled:
With flag enabled: