Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove SUBSCRIBE_TO_ALL_PRODUCTS ff #23418

Merged
merged 22 commits into from
Jul 3, 2024

Conversation

zlwaterfield
Copy link
Contributor

## Changes

This PR removes the subscribe to all products ff, assumes everyone has access and shows the UI based on the subscription level of free, paid or custom.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Tested manually

@zlwaterfield zlwaterfield self-assigned this Jul 2, 2024
@zlwaterfield zlwaterfield requested a review from raquelmsmith July 2, 2024 20:59
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

26 snapshot changes in total. 0 added, 26 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Size Change: -54 B (-0.01%)

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.06 MB -54 B (-0.01%)

compressed-size-action

Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple snapshot issues - you can decide if these should be fixed before moving everyone over to it 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the data that powers this snapshot should be fixed - seems like FFs and surveys aren't subscribed, so they don't show the amount due.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, looks like this doesn't work in dark mode. People can get to dark mode in onboarding if they have an account first - but idk if the initial experience allows them to use dark mode or defaults into light mode?

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

5 snapshot changes in total. 0 added, 5 modified, 0 deleted:

  • chromium: 0 added, 5 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

  • chromium: 0 added, 6 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@zlwaterfield zlwaterfield merged commit 74e7b3d into master Jul 3, 2024
91 checks passed
@zlwaterfield zlwaterfield deleted the zach/subscribe-to-all-products/paid-level-checks branch July 3, 2024 19:43
thmsobrmlr pushed a commit that referenced this pull request Jul 3, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants