-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove SUBSCRIBE_TO_ALL_PRODUCTS ff #23418
chore: remove SUBSCRIBE_TO_ALL_PRODUCTS ff #23418
Conversation
📸 UI snapshots have been updated26 snapshot changes in total. 0 added, 26 modified, 0 deleted:
Triggered by this commit. |
Size Change: -54 B (-0.01%) Total Size: 1.06 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple snapshot issues - you can decide if these should be fixed before moving everyone over to it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the data that powers this snapshot should be fixed - seems like FFs and surveys aren't subscribed, so they don't show the amount due.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, looks like this doesn't work in dark mode. People can get to dark mode in onboarding if they have an account first - but idk if the initial experience allows them to use dark mode or defaults into light mode?
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
## Changes
This PR removes the subscribe to all products ff, assumes everyone has access and shows the UI based on the subscription level of free, paid or custom.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Tested manually