Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(billing): show usage for temporarily free products #23417

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

raquelmsmith
Copy link
Member

@raquelmsmith raquelmsmith commented Jul 2, 2024

Problem

Data warehouse pricing will be launching for users shortly. Beta users will get 30 days notice. We are tracking their usage and want to tell them what their forecasted usage is. Our billing page doesn't currently support this.

Changes

For "temporarily free" product plans, (ie plans without pricing and no free allocation and not inclusion_only), show a gauge with current and projected usage.

For people on the specific data warehouse plan, show a notice saying when we will start to charge them.

Arc 2024-07-02 12 36 39

Also adds some stories for BillingProduct because we have none.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

N/A

How did you test this code?

Added stories

@@ -277,6 +281,23 @@ export const BillingProduct = ({ product }: { product: BillingProductV2Type }):
</div>
</Tooltip>
</div>
) : isTemporaryFreeProduct ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: do you need isTemporaryFreeProduct. It seems to be an unneeded complication. Given this will be removed on August 8th and it's specific to the data warehouse, maybe just use that as the check?

It's not really needed until we support the content of this box to be dynamic from billing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do actually want to keep it there and not make it specific to DW. I think the way we are doing this launch is something we will prob do in the future with other launches - roll out pricing for everyone, give beta users 30 days notice, during which they will need to see their usage. The notice on the interior is specific to data warehouse launch, but it'll be specific to every product launch, so I don't really know how to make it more reusable right now. And I don't really want to add a bunch of fields to billing data to fill it out.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

@raquelmsmith raquelmsmith enabled auto-merge (squash) July 2, 2024 22:35
@raquelmsmith raquelmsmith merged commit aee5a79 into master Jul 2, 2024
91 checks passed
@raquelmsmith raquelmsmith deleted the feat/rms/dw-product-card-no-price branch July 2, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants