Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-warehouse): schema status optional type #23379

Merged
merged 8 commits into from
Jul 2, 2024
Merged

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jul 1, 2024

Problem

Changes

  • adjusts types and tests to account for when schema status isn't set

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

  • manual and adjusted test to account for it

@EDsCODE EDsCODE requested review from Gilbert09 and dmarticus July 1, 2024 21:18
Copy link
Contributor

@dmarticus dmarticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will clear up the customer's bug; so I'm happy to blind stamp despite not knowing the full context behind these changes.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

@EDsCODE EDsCODE merged commit 27506a8 into master Jul 2, 2024
91 checks passed
@EDsCODE EDsCODE deleted the dw-schema-status-bug branch July 2, 2024 00:09
fuziontech pushed a commit that referenced this pull request Jul 2, 2024
* should be optional

* adjust test to account for null status

* Update query snapshots

* Update query snapshots

* func name

* Update query snapshots

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dylan Martin <[email protected]>
zlwaterfield pushed a commit that referenced this pull request Jul 2, 2024
* should be optional

* adjust test to account for null status

* Update query snapshots

* Update query snapshots

* func name

* Update query snapshots

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dylan Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants