fix: strip uuid in schema_helpers with the other fe only fields #23376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
requested changes
Jul 1, 2024
aspicer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes https://github.com/PostHog/company-internal/issues/1423
The call to insights to load a saved retention query was often cache missing. This caused the front-end to not get data and launch a query.
Changes
Add uuid to filters_to_query. This allows us to cache hit.
There is probably another bug on the frontend where /query responses aren't getting saved locally on the fe the same way the insights responses are.
Does this work well for both Cloud and self-hosted?
yes
How did you test this code?
Tested it locally.