feat(web-analytics): Fix group by, remove date range #23367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
changed the title
robbie-c
force-pushed
the
feat/fix-order-by-in-sessions-v2
branch
from
a95eaed to
6436c62
Compare
fuziontech
approved these changes
Jul 1, 2024
fuziontech
pushed a commit
that referenced
this pull request
Jul 2, 2024
* Fix group by, remove date range * Update query snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The sessions v2 table group by doesn't match the order by. This isn't likely to be causing problems but does go against best practice so fix it.
Additionally, we no longer need the date range condition
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Relies on existing tests passing