Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache key interpolation bug #23200

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Conversation

raquelmsmith
Copy link
Member

Problem

Tokens were being written with QuotaLimitingCaches.QUOTA_LIMITER_CACHE_KEYevents instead of the proper @posthog/quota-limits/events due to not using the value of the enum.

Changes

Makes it use the .value and also changes all the tests to use the hard-coded key so that they are actually reflective of reality.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

N/A

How did you test this code?

Tests pass locally.

@raquelmsmith raquelmsmith requested a review from xvello June 24, 2024 17:46
ee/billing/test/test_quota_limiting.py Outdated Show resolved Hide resolved
@raquelmsmith raquelmsmith merged commit 8b3b31a into master Jun 27, 2024
84 checks passed
@raquelmsmith raquelmsmith deleted the fix/quota-limiting-cache-key branch June 27, 2024 17:29
Copy link

sentry-io bot commented Jul 5, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Value after * must be an iterable, not NoneType posthog.tasks.usage_report.send_report_to_billi... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants