feat: Use a background task to set batch export status to running #23136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The large diff lines are just the nesting being removed, actual changes are small! |
tomasfarias
force-pushed
the
feat/use-background-task-to-set-batch-export-to-running
branch
from
62f95a8 to
4ec5623
Compare
Gilbert09
approved these changes
Jun 21, 2024
tomasfarias
force-pushed
the
feat/use-background-task-to-set-batch-export-to-running
branch
2 times, most recently
from
aed05e0 to
9034a2c
Compare
tomasfarias
changed the base branch from
master
to
feat/person-batch-exports-big-query
tomasfarias
force-pushed
the
feat/use-background-task-to-set-batch-export-to-running
branch
2 times, most recently
from
aef5969 to
1285e61
Compare
This allows us to run the task concurrently instead of timing out on it. It also has the additional benefit of removing a lot of nesting levels!
tomasfarias
force-pushed
the
feat/use-background-task-to-set-batch-export-to-running
branch
from
230bb29 to
c10ff4d
Compare
tomasfarias
deleted the
feat/use-background-task-to-set-batch-export-to-running
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Phanatic
pushed a commit
that referenced
this pull request
Jul 8, 2024
…3136) * feat: Use a background task to set batch export status to running This allows us to run the task concurrently instead of timing out on it. It also has the additional benefit of removing a lot of nesting levels! * fix: Type hints and early return * fix: Update type hint * fix: Merge conflicts * fix: Rebase * fix: Bunch of merge conflicts * Update query snapshots * test: Add unit test * Update query snapshots * chore: Rename file * fix: Use new 3.11 alias * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * fix: Use new 3.11 alias * Update query snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are not reliably setting the status of a batch export run to running. We timeout regularly while waiting for it to be done.
Changes
This allows us to run the task concurrently instead of timing out on it. It also has the additional benefit of removing a lot of nesting levels!
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Added unit test.