chore(frontend): Avoid flaky JS breakpoint in TaxonomicPropertyFilter
#23129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
aspicer
approved these changes
Jun 21, 2024
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
useResizeObserver()is notably flaky in visual tests, causing snapshot to flip-flop. This is extremely apparent in theTaxonomicPropertyFiltercomponent, e.g. here: #22764.Changes
useResizeObserver()begone! Let's just use flexbox – it actually seems to yield better (more _flex_ible) results, and it has zero risk of flakiness.