Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): make salt keys a list #23127

Merged
merged 5 commits into from
Jun 21, 2024
Merged

chore(data-warehouse): make salt keys a list #23127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ac5cb3
make it a list
EDsCODE Jun 20, 2024
ca30f8a
Merge branch 'master' into dw-salt-keys
EDsCODE Jun 20, 2024
4502402
Merge branch 'master' into dw-salt-keys
EDsCODE Jun 21, 2024
4399287
Merge branch 'master' into dw-salt-keys
EDsCODE Jun 21, 2024
44e8563
Merge branch 'master' into dw-salt-keys
EDsCODE Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion posthog/settings/web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ def add_recorder_js_headers(headers, path, url):
# We keep the number of buckets low to reduce resource usage on the Prometheus
PROMETHEUS_LATENCY_BUCKETS = [0.1, 0.3, 0.9, 2.7, 8.1, float("inf")]

SALT_KEY = os.getenv("SALT_KEY", "0123456789abcdefghijklmnopqrstuvwxyz")
SALT_KEY = get_list(os.getenv("SALT_KEY", "0123456789abcdefghijklmnopqrstuvwxyz"))

# temporary flag to control new UUID version setting in posthog-js
# is set to v7 to test new generation but can be set to "og" to revert
Expand Down
1 change: 1 addition & 0 deletions posthog/warehouse/data_load/validate_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ async def validate_schema_and_update_table(
# create or update
table_created: DataWarehouseTable | None = await get_table_by_schema_id(_schema_id, team_id)
if table_created:
table_created.credential = data.get("credential")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will save new credential to the table

table_created.url_pattern = new_url_pattern
if incremental:
table_created.row_count = await sync_to_async(table_created.get_count)()
Expand Down
Loading