-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fixed window playback #23126
feat: fixed window playback #23126
Conversation
value: null, | ||
labelInMenu: ( | ||
<div className="flex flex-row gap-2 space-between items-center"> | ||
Follow the user: <IconWindow value={currentWindowIndex} className="text-muted-alt" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't sure of the language on these labels...
Could this just be "Auto"??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like follow the user!
{ | ||
label: <IconWindow value={currentWindowIndex} className="text-muted-alt" />, | ||
value: null, | ||
labelInMenu: <>Follow the user</>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looked during the gif like this option also had an IconWindow
in it. That somewhat confused me but I'm guessing it has changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i realised it didn't make sense :)
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
closes #18150 |
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
When viewing a recording, if there are multiple screens we guesstimate which is the active window and show you that one.
In the past when we've got that wrong folk have asked for the ability to choose one window to watch
Today when viewing a user's bug report I'd have loved to know if we were picking the active window wrong or something else... So, let's let people pick