Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed window playback #23126

Merged
merged 10 commits into from
Jun 21, 2024
Merged

feat: fixed window playback #23126

merged 10 commits into from
Jun 21, 2024

Conversation

pauldambra
Copy link
Member

When viewing a recording, if there are multiple screens we guesstimate which is the active window and show you that one.

In the past when we've got that wrong folk have asked for the ability to choose one window to watch

Today when viewing a user's bug report I'd have loved to know if we were picking the active window wrong or something else... So, let's let people pick

2024-06-20 17 11 45

@pauldambra pauldambra requested a review from daibhin June 20, 2024 16:17
value: null,
labelInMenu: (
<div className="flex flex-row gap-2 space-between items-center">
Follow the user: <IconWindow value={currentWindowIndex} className="text-muted-alt" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure of the language on these labels...

Could this just be "Auto"??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like follow the user!

{
label: <IconWindow value={currentWindowIndex} className="text-muted-alt" />,
value: null,
labelInMenu: <>Follow the user</>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looked during the gif like this option also had an IconWindow in it. That somewhat confused me but I'm guessing it has changed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i realised it didn't make sense :)

Copy link
Contributor

github-actions bot commented Jun 20, 2024

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra pauldambra enabled auto-merge (squash) June 20, 2024 17:53
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra
Copy link
Member Author

closes #18150

@pauldambra pauldambra merged commit 815e9ca into master Jun 21, 2024
92 checks passed
@pauldambra pauldambra deleted the feat/fixed-window-playback branch June 21, 2024 07:25
thmsobrmlr pushed a commit that referenced this pull request Jun 24, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants