Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(livestream): Ignore invalid IP address errors #23118

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Jun 20, 2024

Problem

We're racking up a lot of useless invalid IP address errors. (Sentry)

Changes

There might be Lookup() errors we want to capture, but "invalid IP address" is unlikely to be a problem on our side, so let's ignore it.

@Twixes Twixes requested a review from fuziontech June 20, 2024 13:27
Copy link
Member

@fuziontech fuziontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Twixes Twixes enabled auto-merge (squash) June 20, 2024 13:29
@Twixes Twixes merged commit a46a8e1 into master Jun 20, 2024
80 checks passed
@Twixes Twixes deleted the livestream-ignore-invalid-ips branch June 20, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants